Conversation
✅ Deploy Preview for devspace-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
From claude: Adversarial Review — fix-docs branch FAIL — Stale yarn.lock (medium) mdx-mermaid@^v1.3.0 and mermaid@^11.12.3 are still present as orphaned top-level entries in docs/yarn.lock PASS — headingPrefix refactor Logic is correct: depth + 1 preserves prior behavior, cap at 6 is the stated fix. All three boundary cases PASS — Versioned sidebar ID stripping FAIL — Stale yarn.lock (medium) mdx-mermaid@^v1.3.0 and mermaid@^11.12.3 are still present as orphaned top-level entries in PASS — headingPrefix refactor Logic is correct: depth + 1 preserves prior behavior, cap at 6 is the stated fix. All three boundary PASS — Versioned sidebar ID stripping Removing version-4.x/ and version-5.x/ prefixes from doc IDs, and renaming "version-4.x/adminSidebar" → PASS — Mermaid removal No MDX file under docs/pages/ or docs/versioned_docs/ uses a component or mermaid fenced PASS — Schema description fixes The ${runtime.image.my-image.tag} → ${runtime.images.my-image.tag} typo (missing s) is consistently PASS — patches.mdx import FragmentInfoPrintConfig is imported and used at line 219. The partial (_partials/tip-print-config.mdx) One nitpick — test case name The test case "top level" at depth=1 actually produces ## (h2), not h1. This is technically correct Summary: One real fix needed — run cd docs && yarn install to remove the stale mermaid lockfile entries |
Fix generators, for example only 6 #'s are allowed now. Signed-off-by: Ryan Swanson <ryan.swanson@loft.sh>
Fix generators, for example only 6 #'s are allowed now.
What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix
/kind documentation
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves #
Please provide a short message that should be published in the DevSpace release notes
Fixed an issue where DevSpace ...
What else do we need to know?